Findbugs: More findbugs fixes. Including but not limited to: null check fixes and some synchronization

2013-11-10 22:20:13 +00:00
parent 35fb332c2c
commit 5c38d5a6c9
23 changed files with 15 additions and 37 deletions
--- a/apps/streaming/java/src/net/i2p/client/streaming/ConnectionDataReceiver.java
+++ b/apps/streaming/java/src/net/i2p/client/streaming/ConnectionDataReceiver.java
@@ -93,7 +93,8 @@ class ConnectionDataReceiver implements MessageOutputStream.DataReceiver {

        if (doSend) {
            PacketLocal packet = send(buf, off, size);
-            if (packet == null) return _dummyStatus;
+            // this shouldn't be null
+            //if (packet == null) return _dummyStatus;
            
            //dont wait for non-acks
            if ( (packet.getSequenceNum() > 0) || (packet.isFlagSet(Packet.FLAG_SYNCHRONIZE)) )