I2P_Developers/i2p.plugins.i2pcontrol
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed #1524, check type of input parameter.

Browse Source
This commit is contained in:
dev
2016-01-18 21:10:26 +00:00
parent df5a9a60a5
commit 08b125f5e4
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/java/net/i2p/i2pcontrol/servlets/jsonrpc2handlers/NetworkSettingHandler.java
View File

@ -250,12 +250,13 @@ public class NetworkSettingHandler implements RequestHandler {
Integer percent;
try{
percent = Integer.parseInt(inParam);
if (percent < 0)
if (percent < 0 || percent > 100 || inParam.length() == 0) {
throw new NumberFormatException();
}
} catch (NumberFormatException e){
return new JSONRPC2Response(
new JSONRPC2Error(JSONRPC2Error.INVALID_PARAMS.getCode(),
"\"i2p.router.net.bw.share\" A positive integer must supplied, " + inParam + " isn't valid"),
"\"i2p.router.net.bw.share\" A positive integer must supplied, \"" + inParam + "\" isn't valid"),
req.getID());
}
_context.router().saveConfig(Router.PROP_BANDWIDTH_SHARE_PERCENTAGE, inParam);
@ -272,8 +273,9 @@ public class NetworkSettingHandler implements RequestHandler {
Integer rate;
try{
rate = Integer.parseInt(inParam);
if (rate < 0)
if (rate < 0 || inParam.length() == 0) {
throw new NumberFormatException();
}
} catch (NumberFormatException e){
return new JSONRPC2Response(
new JSONRPC2Error(JSONRPC2Error.INVALID_PARAMS.getCode(),
@ -301,7 +303,7 @@ public class NetworkSettingHandler implements RequestHandler {
Integer rate;
try{
rate = Integer.parseInt(inParam);
if (rate < 0)
if (rate < 0 || inParam.length() == 0)
throw new NumberFormatException();
} catch (NumberFormatException e){
return new JSONRPC2Response(